Move LegacyBindingEnabled / JavascriptBindingPropertyName to per browser settings#5231
Open
campersau wants to merge 2 commits intocefsharp:masterfrom
Open
Move LegacyBindingEnabled / JavascriptBindingPropertyName to per browser settings#5231campersau wants to merge 2 commits intocefsharp:masterfrom
campersau wants to merge 2 commits intocefsharp:masterfrom
Conversation
Contributor
📝 WalkthroughWalkthroughJavaScript binding state was moved from wrapper-level fields to per-browser Changes
Sequence DiagramsequenceDiagram
participant Browser as Browser Instance
participant Cache as Per-Browser Cache
participant Factory as Settings Factory
participant Context as JS Context
participant Binder as Binding Logic
Browser->>Cache: OnBrowserCreated(browserId) -> GetOrAdd(browserId, factory)
Cache->>Factory: invoke JavascriptBindingSettingsFactory(int)
Factory-->>Cache: return JavascriptBindingSettings
Cache-->>Browser: cached settings associated with browserId
Browser->>Context: OnContextCreated(frame)
Context->>Cache: TryGetValue(browserId)
Cache-->>Context: JavascriptBindingSettings (or null)
Context->>Binder: If settings != null -> evaluate settings (names, legacy flag)
Binder-->>Context: Apply global property / legacy root bindings as per settings
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
CefSharp.Test/JavascriptBinding/JavascriptBindingTests.cs (1)
91-122: Consider adding isolation assertions to verify per-browser settings don't leak.The test verifies that each browser has its expected binding object, which is good. However, to fully validate per-browser isolation, consider also verifying that:
browser1does not havewindow.cefSharp(since it has a custom name)browser1does not havewindow.bindingApiObject2browser2does not havewindow.bindingApiObject1This would catch any accidental cross-contamination between browser instances sharing a render process.
💡 Example additional assertions
// After the existing assertions, add isolation checks: var isolation1 = await browser1.EvaluateScriptAsync("typeof window.cefSharp === 'undefined'"); Assert.True(isolation1.Success, isolation1.Message); Assert.True((bool)isolation1.Result, "browser1 should not have default cefSharp"); var isolation2 = await browser2.EvaluateScriptAsync("typeof window.cefSharp === 'undefined'"); Assert.True(isolation2.Success, isolation2.Message); Assert.True((bool)isolation2.Result, "browser2 should not have default cefSharp");🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CefSharp.Test/JavascriptBinding/JavascriptBindingTests.cs` around lines 91 - 122, The test ShouldWorkWhenUsingCustomGlobalObjectNameInMultipleBrowsers currently checks that each browser exposes its expected global, but doesn't assert that other globals are absent; add additional EvaluateScriptAsync checks and assertions (using browser1, browser2, browser3 and Assert.True/Assert.False) after the existing assertions to verify browser1 does not have window.cefSharp or window.bindingApiObject2, browser2 does not have window.cefSharp or window.bindingApiObject1, and browser3 does not have the custom names, ensuring per-browser isolation and no render-process leakage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@CefSharp.Test/JavascriptBinding/JavascriptBindingTests.cs`:
- Around line 91-122: The test
ShouldWorkWhenUsingCustomGlobalObjectNameInMultipleBrowsers currently checks
that each browser exposes its expected global, but doesn't assert that other
globals are absent; add additional EvaluateScriptAsync checks and assertions
(using browser1, browser2, browser3 and Assert.True/Assert.False) after the
existing assertions to verify browser1 does not have window.cefSharp or
window.bindingApiObject2, browser2 does not have window.cefSharp or
window.bindingApiObject1, and browser3 does not have the custom names, ensuring
per-browser isolation and no render-process leakage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4a007db3-794d-450b-997f-c0d3af1bb52d
📒 Files selected for processing (4)
CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.cppCefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.hCefSharp.BrowserSubprocess.Core/JavascriptBindingSettings.hCefSharp.Test/JavascriptBinding/JavascriptBindingTests.cs
|
✅ Build CefSharp 146.0.70-CI5462 completed (commit 205dafcb77 by @campersau) |
|
❌ Build CefSharp 146.0.70-CI5463 failed (commit 834355dc39 by @campersau) |
amaitland
force-pushed
the
perbrowserbindingname
branch
from
1c471bb to
889332f
Compare
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
CefSharp.Test/JavascriptBinding/JavascriptBindingTests.cs (1)
91-154: Well-structured test for per-browser binding isolation.The test correctly validates that each browser instance maintains its own
JavascriptBindingApiGlobalObjectNamesetting, ensuring the per-browser settings migration works as intended.Optional: The sequential
WaitForInitialLoadAsynccalls could be parallelized for faster test execution:await Task.WhenAll( browser1.WaitForInitialLoadAsync(), browser2.WaitForInitialLoadAsync(), browser3.WaitForInitialLoadAsync());🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CefSharp.Test/JavascriptBinding/JavascriptBindingTests.cs` around lines 91 - 154, The three sequential waits for initial load slow the test; replace the three separate await browserX.WaitForInitialLoadAsync() calls with a single parallel wait using Task.WhenAll to await browser1, browser2 and browser3 simultaneously (update the calls around WaitForInitialLoadAsync for those browser variables).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@CefSharp.Test/JavascriptBinding/JavascriptBindingTests.cs`:
- Around line 91-154: The three sequential waits for initial load slow the test;
replace the three separate await browserX.WaitForInitialLoadAsync() calls with a
single parallel wait using Task.WhenAll to await browser1, browser2 and browser3
simultaneously (update the calls around WaitForInitialLoadAsync for those
browser variables).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c8376f3b-00fa-460a-b799-3c3b16eb32d3
📒 Files selected for processing (4)
CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.cppCefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.hCefSharp.BrowserSubprocess.Core/JavascriptBindingSettings.hCefSharp.Test/JavascriptBinding/JavascriptBindingTests.cs
🚧 Files skipped from review as they are similar to previous changes (1)
- CefSharp.BrowserSubprocess.Core/JavascriptBindingSettings.h
|
❌ Build CefSharp 146.0.100-CI5466 failed (commit 72238078aa by @campersau) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: Addresses #5229 (comment)
Summary:
Changes:
How Has This Been Tested?
Unittests
Screenshots (if appropriate):
Types of changes
Checklist:
Summary by CodeRabbit
New Features
Improvements
Tests